Fix OLED SPI interfaces#498
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes OLED SPI interfaces where MISO was previously left disconnected and unmodeled by adding a DigitalBidirNotConnected dummy block, matching the existing pattern in Er_Oled_022.
Changes:
- Add
DigitalBidirNotConnecteddummy MISO connection inEr_Oled_096_1_1SPI branch. - Add the same dummy MISO connection in
Er_Oled_096_1cSPI branch. - Add new compile tests covering I2C and SPI configurations for
Er_Oled_096_1_1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| edg/parts/display/oled/Er_Oled_096_1_1.py | Connects SPI MISO to a DigitalBidirNotConnected dummy. |
| edg/parts/display/oled/Er_Oled_096_1c.py | Connects SPI MISO to a DigitalBidirNotConnected dummy. |
| edg/parts/display/oled/test_oled_i2c_spi.py | New compile tests for I2C and SPI variants of Er_Oled_096_1_1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, they led MISO disconnected and unmodeled. This adds a dummy connection.